snow/wireguard-go
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

device: remove nil elem check in finalizers

Browse source 
This is not necessary, and removing it speeds up detection of UAF bugs.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
This commit is contained in:
Josh Bleecher Snyder 2021-02-09 08:15:21 -08:00 committed by Jason A. Donenfeld
parent 9e728c2eb0
commit ecceaadd16
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
device/channels.go
View file

@ -87,9 +87,6 @@ func newAutodrainingInboundQueue(device *Device) *autodrainingInboundQueue {
for { for {
select { select {
case elem := <-q.c: case elem := <-q.c:
if elem == nil {
continue
}
elem.Lock() elem.Lock()
device.PutMessageBuffer(elem.buffer) device.PutMessageBuffer(elem.buffer)
device.PutInboundElement(elem) device.PutInboundElement(elem)
@ -118,9 +115,6 @@ func newAutodrainingOutboundQueue(device *Device) *autodrainingOutboundQueue {
for { for {
select { select {
case elem := <-q.c: case elem := <-q.c:
if elem == nil {
continue
}
elem.Lock() elem.Lock()
device.PutMessageBuffer(elem.buffer) device.PutMessageBuffer(elem.buffer)
device.PutOutboundElement(elem) device.PutOutboundElement(elem)