From ecceaadd168ce682695acf1a5c004ef89e4927eb Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Tue, 9 Feb 2021 08:15:21 -0800 Subject: [PATCH] device: remove nil elem check in finalizers This is not necessary, and removing it speeds up detection of UAF bugs. Signed-off-by: Josh Bleecher Snyder --- device/channels.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/device/channels.go b/device/channels.go index 1e3e206..bf78868 100644 --- a/device/channels.go +++ b/device/channels.go @@ -87,9 +87,6 @@ func newAutodrainingInboundQueue(device *Device) *autodrainingInboundQueue { for { select { case elem := <-q.c: - if elem == nil { - continue - } elem.Lock() device.PutMessageBuffer(elem.buffer) device.PutInboundElement(elem) @@ -118,9 +115,6 @@ func newAutodrainingOutboundQueue(device *Device) *autodrainingOutboundQueue { for { select { case elem := <-q.c: - if elem == nil { - continue - } elem.Lock() device.PutMessageBuffer(elem.buffer) device.PutOutboundElement(elem)