Commit graph

30 commits

Author SHA1 Message Date
Doug Torrance 624b2898fe wmgeneral: Don't call free on pointers we haven't malloced.
Could cause occasional segfaults.
2015-05-20 10:44:41 +01:00
Doug Torrance a9b73f2fd6 wmgeneral: Fix segfault if newline encountered in parse_rcfile.
From a patch for wmppp.app by Chris Gray <cgray@tribsoft.com> submitted to
Debian to fix several bugs [1].

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=27997
2015-05-20 10:44:41 +01:00
Doug Torrance cd30d4127d wmgeneral: Add proper copyright headers; fix changelog formatting. 2015-05-20 10:44:41 +01:00
Doug Torrance afd3d56aea wmgeneral: Use #includes from include-what-you-use. 2015-05-20 10:44:41 +01:00
Doug Torrance 6b1ed40882 wmgeneral: Use field width limits for scanf.
This fixes "(portability) scanf without field width limits can crash with
huge input data on some versions of libc" warning from cppcheck.

We choose 10 as the field width limit as it is the number of characters in
2^31-1, the largest int.
2015-05-20 10:44:41 +01:00
Doug Torrance a0f16b945a wmgeneral: Reduce scope of several variables.
Also took the opportunity to fix some whitespace formatting.
2015-05-20 10:44:41 +01:00
Doug Torrance 6dc4716c29 wmgeneral: Merge 2003-10-10 version from wmmon and wmtime.
Note that this was a fork of the earlier 1998-05-02 version and didn't
contain the later changes.  Therefore we merge the best of both versions.

wmtime had some additional unnecessary dummy variables, so we use the wmmon
version.
2015-05-20 10:44:41 +01:00
Doug Torrance a680f87666 wmgeneral: Bump to 1998-09-14 version found in wmckgmail, wmitime, wmsmp.app, wmSMPmon, and wmtz.
Note that wmckgmail and wmtz were identical; this is the version we use.
wmSMPmon differed only with some whitespace.

wmitime differed only with a bugfix (a segfault when -display is given with
no argument), but this will be fixed again in the next commit.

wmsm.app had patched wmgeneral to work with its xpm; instead we patch its
xpm to work with wmgeneral.
2015-05-20 10:44:40 +01:00
Doug Torrance 6c8c14e710 wmgeneral: Bump to 1998-09-11 version found in wmcpufreq and wmppp.app.
We update the dockapps with the older 1998-05-02 version (wmfsm, wmifs, and
wmkeys), and also remove trailing whitespace from the wmcpufreq copy.
2015-05-20 10:44:40 +01:00
Doug Torrance c312b63d2d wmfsm: Bump to version 0.35. 2015-01-22 11:12:11 +00:00
Doug Torrance 7d029d2db1 wmfsm: Update README with new installation instructions. 2015-01-22 11:12:11 +00:00
Doug Torrance e8d40e3115 wmfsm: Combine ChangeLog and ChangeLog.old.
As ChangeLog is no longer automatically generated by arch, there is no need
to keep these files separate.
2015-01-22 11:12:10 +00:00
Doug Torrance b117ac7474 wmfsm: Impove version number handling.
In particular,
- Add new --version command line option.  (This was already documented in
  the manpage.)  Remove this information from the --help text.  Also took
  the opportunity to properly align the --fire line in the --help text.
- Remove WMFSM_VERSION macro in favor of PACKAGE_VERSION from autconf.
- Remove hard-coded version number at top of source file for
  maintainability.
2015-01-22 11:12:10 +00:00
Doug Torrance d379db1092 wmfsm: Update with new contact information. 2015-01-22 11:12:10 +00:00
Doug Torrance d9d5dd1343 wmfsm: Add -a command line option to select appearance at runtime.
Also update Makefile to install appearance XPMs during "make install".
2015-01-22 11:12:10 +00:00
Doug Torrance fa0bdfaeba wmfsm: Add --with-xpm option to configure to select appearance at compile time.
Note that wmfsm/wmfsm_master.xpm has been removed, as it is now created as a
symlink during configure.  It is also removed by "make clean".
2015-01-22 11:12:10 +00:00
Doug Torrance 9c22691eda wmfsm: Remove TODO; all the items have been done. 2015-01-22 11:12:10 +00:00
Doug Torrance 9b9ef2f6d2 wmfsm: Fix -Wunused-result compiler warnings.
In particular, if fscanf does not read the expected number of items from
/etc/mtab, print a warning message.
2015-01-22 11:12:10 +00:00
Doug Torrance 331af1daa2 wmfsm: Update COPYING from http://www.gnu.org/licenses/gpl-2.0.txt. 2015-01-22 11:12:10 +00:00
Doug Torrance 18898f871f wmfsm: Update Free Software Foundation address in copyright header. 2015-01-22 11:12:10 +00:00
Doug Torrance 70c80a41a5 wmfsm: Remove trailing whitespace. 2015-01-22 11:12:10 +00:00
Doug Torrance bec2a56a92 wmfsm: Update sample configuration file.
Patch by Arthur Korn <arthur@korn.ch> to fix Debian bug #226298 [1].

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?archive=yes&bug=226298
2015-01-22 11:12:10 +00:00
Doug Torrance 2401e76fa4 wmfsm: Improve manpage.
In particular,
- Apply, with some modification, a patch by Jari Aalto
  <jari.aalto@poboxes.com> to clarify the format of the configuration file.
  See [1].
- Escape minus signs to avoid hyphen-used-as-minus-sign Lintian warning in
  the Debian package.
- Remove docbook-to-man comments to avoid manpage-has-errors-from-man
  Lintian warning in the Debian package.
- Add commas between short and long options for readability.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?archive=yes&bug=226274
2015-01-22 11:12:10 +00:00
Doug Torrance aef6c49d83 wmfsm: Apply further Debian patches.
The individual patches no longer seem to exist, so I submit them together.
According to debian/changelog entries by Arthur Korn <arthur@debian.org>,
these patches include:
* fixed memleak introduced in 0.34-2 with the patch by Timo Benk.
  global char *mp[] was assigned the result of stdup() repeatedly
  without free. My ugly fix is to free it all up at the beginning of
  readFileSystems(). Now I'm a proud Perl coder ... closes: #196057
* memleak news: avoid it if there are more than 9 filesystems too.
* Fixed filesystem name corruption, thanks to Ralf Horstmann and Cristian
  Ionescu-Idbohrn for the patch.
2015-01-22 11:12:10 +00:00
Doug Torrance 3eb9307a7b wmfsm: Read newly mounted filesystems.
Patch by Timo Benk <t_benk@web.de> to fix Debian bug #186826 [1].

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?archive=yes&bug=186826
2015-01-22 11:12:10 +00:00
Doug Torrance b143ff46a6 wmfsm: Hide "system" file systems.
Patch [1] by roma1390 and Michele Noberasco to fix Gentoo bug #50148 [2].

[1] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/x11-plugins/wmfsm/files/wmfsm-0.34.linux-fs.patch
[2] https://bugs.gentoo.org/show_bug.cgi?id=50148
2015-01-22 11:12:10 +00:00
Doug Torrance 443124b998 wmfsm: Autotools updates.
In particular,
- Update AM_INIT_AUTOMAKE to silence "two- and three-arguments forms are
  deprecated" warnings.
- Update AC_DEFINEs to silence "missing template" warnings.
2015-01-22 11:12:10 +00:00
Doug Torrance 4ece1f4ee8 wmfsm: Rename configure.in to configure.ac. 2015-01-22 11:12:10 +00:00
Doug Torrance 8f6c8d13a6 wmfsm: Remove autotools-generated files. 2015-01-22 11:12:10 +00:00
Doug Torrance 34d838198a wmfsm: Add version 0.34 to repository.
Obtained from [1].

[1] http://snapshot.debian.org/archive/debian/20050312T000000Z/pool/main/w/wmfsm/wmfsm_0.34.orig.tar.gz
2015-01-22 11:11:18 +00:00