In particular, if HOME is undefined, then a segmentation fault will occur.
Also, if HOME is at least 245 characters, then a buffer overflow will occur.
We check for these conditions and exit with an error message instead.
Patch obtained from Debian package [1].
[1] https://sources.debian.net/src/wmfsm/0.35-1/debian/patches/handle_HOME_errors.patch/
The first argument for the function initialize_gnutls is an intptr_t
so wmbiff fails to build from source. This patch changes the current
int to intptr_t.
Signed-off-by: Rodolfo García Peñas (kix) <kix@kix.es>
This patch solves a bug and a warning:
- The dockapp wmkeys uses the getline function, that is the same
function provided by stdio.h. This patch changes the function
name to getline_wmkeys.
- The main function returns void, and should return integer. This
patch includes the return 0 at the function end and it changes
the function prototype.
Signed-off-by: Rodolfo García Peñas (kix) <kix@kix.es>
This patch includes the libwmgeneral library in the libdockapp
library.
The new library is now version 3 (previous was version 2) and it
includes the new include folder in $libdir/libdockapp.
The wmgeneral files were moved from the previous folder (libwmgeneral)
and the folder is now removed.
Signed-off-by: Rodolfo García Peñas (kix) <kix@kix.es>
This patch show how to include the wmgeneral in a previous dockapps.
The change is easy, remove the wmgeneral folder an include the
-lwmgeneral in the libraries linking.
This patch includes the library wmgeneral. The wmgeneral library
is used in a lot of dockapps:
$ find . -name wmgeneral
./wmkeys/wmgeneral
./wmtime/wmgeneral
./wmtz/wmgeneral
./wmsm.app/wmgeneral
./wmcpufreq/wmgeneral
./wmtv/src/wmgeneral
./wmSMPmon/wmgeneral
./wmckgmail/wmgeneral
./wmifs/wmgeneral
./wmbiff/wmgeneral
./wmfsm/wmgeneral
./wmsun/wmgeneral
./wmmon/wmgeneral
./wmitime/wmgeneral
./wmppp.app/wmgeneral
So, any change in the wmgeneral needs change a lot of dockapps.
I used the wmmon dockapp to move the wmgeneral and then I adjust the
wmmon to use the library. The library must be installed in the system
to build wmmon (wmmon uses the .h files) and is needed to run wmmon
(wmmon uses the libwmgeneral.so shared library).
I did not include any Changelog/README/... file to announce the change
in the libwmgeneral folder.
Signed-off-by: Rodolfo García Peñas (kix) <kix@kix.es>
In particular,
- Remove INCDIR, DESTDIR, and LIBDIR definitions.
- Add PREFIX, BINDIR, MANDIR, and INSTALL definitions.
- Add -lm to LIBS.
- Drop COPTS, uname, and INCDIR and add CPPFLAGS and CFLAGS when compiling.
- Drop COPTS, SYSTEM, INCDIR, and LIBDIR and add LDFLAGS when linking.
- Use INSTALL when installing, create installation directories, use new
BINDIR and MANDIR directories.
