Fix sanity errors

Fix sanity errors

.ansible-lint

@@ -0,0 +1,2 @@
+skip_list:
+  - '208'

changelogs/CHANGELOG.rst

@@ -4,6 +4,15 @@ Ansible Network Collection for Dell EMC OS9 Release Notes
 
 .. contents:: Topics
 
+v1.0.4
+======
+
+Release Summary
+---------------
+
+- Fixed sanity error found during the sanity tst of automation hub upload
+- Fix issue in using list of strings for commands argument for os10_command module (https://github.com/ansible-collections/dellemc.os9/issues/15)
+
 v1.0.3
 ======
 

changelogs/changelog.yaml

@@ -92,8 +92,16 @@ releases:
     - 1.0.2.yaml
     release_date: '2020-08-18'
   1.0.3:
-    chnages:
+    changes:
       release_summary: Added bug fixes for bugs found during System Test.
     fragments:
     - 1.0.3.yaml
-    release_date: '2020-10-09'
+    release_date: '2020-10-09'
+  1.0.4:
+    changes:
+      bugfixes:
+        - Fixed sanity error found during the sanity tst of automation hub upload
+        - Fix issue in using list of strings for commands argument for os10_command module (https://github.com/ansible-collections/dellemc.os9/issues/15)
+    fragments:
+    - 1.0.4.yaml
+    release_date: '2021-02-15'

galaxy.yml

@@ -9,7 +9,7 @@ name: os9
 namespace: dellemc
 readme: README.md
 tags: [dell, dellemc, os9, emc, networking]
-version: 1.0.3
+version: 1.0.4
 repository: 'https://github.com/ansible-collections/dellemc.os9'
 documentation: 'https://github.com/ansible-collections/dellemc.os9/tree/master/docs'
 homepage: 'https://github.com/ansible-collections/dellemc.os9'

plugins/doc_fragments/os9.py

@@ -61,7 +61,6 @@ options:
           task, the value of environment variable C(ANSIBLE_NET_AUTHORIZE) will be
           used instead.
         type: bool
-        default: false
       auth_pass:
         description:
         - Specifies the password to use if required to enter privileged mode on the

plugins/modules/os9_command.py

@@ -36,7 +36,6 @@ options:
         module is not returned until the condition is satisfied or
         the number of retries has expired.
     type: list
-    elements: dict
     required: true
   wait_for:
     description:
@@ -171,7 +170,7 @@ def main():
     """
     argument_spec = dict(
         # { command: <str>, prompt: <str>, response: <str> }
-        commands=dict(type='list', elements='dict', required=True),
+        commands=dict(type='list', required=True),
 
         wait_for=dict(type='list', elements='str'),
         match=dict(default='all', choices=['all', 'any']),

roles/os9_aaa/meta/main.yml

@@ -1,8 +1,10 @@
 # copyright (c) 2017-2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
-  description: The os9_aaa role facilitates the configuration of Authentication Authorization Acccounting (AAA) attributes in devices running Dell EMC Networking Operating Systems. 
+  description: >
+               The os9_aaa role facilitates the configuration of Authentication Authorization Acccounting (AAA) attributes
+               in devices running Dell EMC Networking Operating Systems.
   license:  GPLv3
   min_ansible_version: 2.9.6
 
@@ -11,7 +13,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
     - os9

roles/os9_aaa/tasks/main.yml

@@ -10,8 +10,8 @@
    register: generate_output
 
  - name: "Provisioning AAA configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_aaa.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_acl/meta/main.yml

@@ -1,8 +1,8 @@
 # Copyright (c) 2017-2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
-  description: The os9_acl role facilitates the configuration of access control list (ACL) attributes in devices running Dell EMC Networking Operating Systems. 
+  description: The os9_acl role facilitates the configuration of access control list (ACL) attributes in devices running Dell EMC Networking Operating Systems.
   license:  GPLv3
   min_ansible_version: 2.9.6
 
@@ -11,7 +11,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
     - os9

roles/os9_acl/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning ACL configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_acl.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_bgp/meta/main.yml

@@ -12,7 +12,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
     - os9

roles/os9_bgp/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning BGP configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_bgp.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_copy_config/meta/main.yml

@@ -1,10 +1,10 @@
 # Copyright (c) 2020 Dell Inc.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
-  description: > 
+  description: >
-                This role shall be used to push the backup running configuration into the device. 
+               This role shall be used to push the backup running configuration into the device.
-                This role shall merge the configuration in the template file with the running configuration of the device 
+               This role shall merge the configuration in the template file with the running configuration of the device
   license:  GPLv3
   min_ansible_version: 2.9.6
 
@@ -13,7 +13,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
     - os9

roles/os9_copy_config/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
-# tasks file for dellemc.os9.os9_copy_config 
+# tasks file for dellemc.os9.os9_copy_config
  - name: "Merge the config file to running configuration for OS9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: "{{ hostname }}.j2"
-   when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9") 
+   when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
-#   notify: save config os9
+#   notify: save config os9

roles/os9_dcb/meta/main.yml

@@ -1,8 +1,10 @@
 # Copyright (c) 2020 Dell Inc.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
-  description: The os9_dcb role facilitates the configuration of Data Center Bridging (DCB) attributes in devices running Dell EMC Networking Operating Systems. 
+  description: >
+               The os9_dcb role facilitates the configuration of Data Center Bridging (DCB) attributes in devices
+               running Dell EMC Networking Operating Systems.
   license:  GPLv3
   min_ansible_version: 2.9.6
 
@@ -11,7 +13,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
     - os9

roles/os9_dcb/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning DCB configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_dcb.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_dns/meta/main.yml

@@ -1,7 +1,7 @@
 # Copyright (c) 2020 Dell Inc.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
   description: The os9_dns role facilitates the configuration DNS attributes in devices running Dell EMC Networking Operating Systems.
   license:  GPLv3
   min_ansible_version: 2.9.6
@@ -11,7 +11,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
     - os9

roles/os9_dns/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning DNS configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_dns.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_ecmp/meta/main.yml

@@ -1,8 +1,8 @@
 # Copyright (c) 2020 Dell Inc.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
-  description: The os9_ecmp role facilitates the configuration of ECMP group attributes in devices running Dell EMC Networking Operating Systems. 
+  description: The os9_ecmp role facilitates the configuration of ECMP group attributes in devices running Dell EMC Networking Operating Systems.
   license:  GPLv3
   min_ansible_version: 2.9.6
 
@@ -11,7 +11,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
     - os9

roles/os9_ecmp/tasks/main.yml

@@ -10,8 +10,8 @@
    register: generate_output
 
  - name: "Provisioning ECMP configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_ecmp.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_interface/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning interface configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_interface.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_lag/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning LAG configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_lag.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_lldp/meta/main.yml

@@ -1,10 +1,10 @@
 # Copyright (c) 2017-2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
   description: >
-               The os9_lldp role facilitates the configuration of Link Layer Discovery Protocol(LLDP) attributes in devices 
+               The os9_lldp role facilitates the configuration of Link Layer Discovery Protocol(LLDP) attributes in devices
-               running Dell EMC Networking Operating Systems. 
+               running Dell EMC Networking Operating Systems.
   license:  GPLv3
   min_ansible_version: 2.9.6
 
@@ -13,7 +13,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
     - os9

roles/os9_lldp/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning LLDP configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_lldp.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_logging/meta/main.yml

@@ -1,4 +1,3 @@
-  
 # Copyright (c) 2020 Dell Inc.
 ---
 galaxy_info:
@@ -10,10 +9,10 @@ galaxy_info:
 
   platforms:
   - name: os9
-  
+
   galaxy_tags:
     - networking
     - dell
     - emc
     - dellemc
-    - os9
+    - os9

roles/os9_logging/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning logging configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_logging.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_ntp/meta/main.yml

@@ -1,9 +1,9 @@
 # Copyright (c) 2020 Dell Inc.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
   description: The os9_ntp role facilitates the configuration of NTP attributes in devices running Dell EMC Networking Operating Systems.
-  company: Dell Inc 
+  company: Dell Inc
   license:  GPLv3
   min_ansible_version: 2.9.6
 
@@ -12,7 +12,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
-    - os9
+    - os9

roles/os9_ntp/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning NTP configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_ntp.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_prefix_list/meta/main.yml

@@ -1,8 +1,8 @@
 # Copyright (c) 2017-2020 Dell Inc.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
-  description: The os9_prefix_list role facilitates the configuration of prefix list attributes in devices running Dell EMC Networking Operating Systems. 
+  description: The os9_prefix_list role facilitates the configuration of prefix list attributes in devices running Dell EMC Networking Operating Systems.
   license:  GPLv3
   min_ansible_version: 2.9.6
 
@@ -11,7 +11,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
-    - os9
+    - os9

roles/os9_prefix_list/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning prefix list configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_prefix_list.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_sflow/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning sflow configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_sflow.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_snmp/meta/main.yml

@@ -9,10 +9,10 @@ galaxy_info:
 
   platforms:
   - name: os9
-  
+
   galaxy_tags:
     - networking
     - dell
     - emc
     - dellemc
-    - os9 
+    - os9

roles/os9_snmp/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning SNMP configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_snmp.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_system/meta/main.yml

@@ -1,9 +1,9 @@
 # Copyright (c) 2020 Dell Inc.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
   description: The os9_system role facilitates the configuration of system attributes in devices running Dell EMC Networking Operating Systems.
-  company: Dell Inc 
+  company: Dell Inc
   license:  GPLv3
   min_ansible_version: 2.9.6
 
@@ -12,7 +12,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
-    - os9
+    - os9

roles/os9_system/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning system configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_system.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_users/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning users configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_users.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_vlan/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning VLAN configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_vlan.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_vlt/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning VLT configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_vlt.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_vrf/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning VRF configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_vrf.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_vrrp/meta/main.yml

@@ -1,10 +1,10 @@
 # Copyright (c) 2020 Dell Inc.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
   description: >
-       The os9_vrrp role facilitates the configuration of Virtual Router Redundancy Protocol (VRRP) attributes in 
+               The os9_vrrp role facilitates the configuration of Virtual Router Redundancy Protocol (VRRP) attributes in
-       devices running Dell EMC Networking Operating Systems.
+               devices running Dell EMC Networking Operating Systems.
   license: GPLv3
   min_ansible_version: 2.9.6
 
@@ -13,7 +13,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - dellemc
     - emc
-    - os9
+    - os9

roles/os9_vrrp/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning VRRP configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_vrrp.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

roles/os9_xstp/meta/main.yml

@@ -1,19 +1,18 @@
 # Copyright (c) 2020 Dell Inc.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
   description: The os9_xstp role facilitates the configuration of STP attributes in devices running Dell EMC Networking Operating Systems.
-  company: Dell Inc 
+  company: Dell Inc
   license:  GPLv3
   min_ansible_version: 2.9.6
 
   platforms:
   - name: os9
 
-
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - dellemc
     - emc
-    - os9
+    - os9

roles/os9_xstp/tasks/main.yml

@@ -9,8 +9,8 @@
    register: generate_output
 
  - name: "Provisioning xSTP configuration for os9"
-   os9_config:
+   dellemc.os9.os9_config:
       src: os9_xstp.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os9.os9")
 #   notify: save config os9
-   register: output
+   register: output

tests/sanity/ignore-2.10.txt

@@ -1,3 +1,4 @@
 plugins/action/os9.py action-plugin-docs
 plugins/modules/os9_config.py validate-modules:parameter-list-no-elements
-plugins/modules/os9_facts.py validate-modules:parameter-list-no-elements
+plugins/modules/os9_facts.py validate-modules:parameter-list-no-elements
+plugins/modules/os9_command.py validate-modules:parameter-list-no-elements

tests/sanity/ignore-2.11.txt

@@ -1,3 +1,4 @@
 plugins/action/os9.py action-plugin-docs
 plugins/modules/os9_config.py validate-modules:parameter-list-no-elements
-plugins/modules/os9_facts.py validate-modules:parameter-list-no-elements
+plugins/modules/os9_facts.py validate-modules:parameter-list-no-elements
+plugins/modules/os9_command.py validate-modules:parameter-list-no-elements

tests/sanity/ignore-2.9.txt

@@ -1,31 +1 @@
-plugins/module_utils/network/dellos9/dellos9.py future-import-boilerplate
+plugins/action/os9.py action-plugin-docs
-plugins/module_utils/network/dellos9/dellos9.py metaclass-boilerplate
-plugins/modules/dellos9_command.py validate-modules:doc-default-does-not-match-spec
-plugins/modules/dellos9_command.py validate-modules:doc-missing-type
-plugins/modules/dellos9_command.py validate-modules:doc-required-mismatch
-plugins/modules/dellos9_command.py validate-modules:parameter-list-no-elements
-plugins/modules/dellos9_command.py validate-modules:parameter-type-not-in-doc
-plugins/modules/dellos9_command.py validate-modules:undocumented-parameter
-plugins/modules/dellos9_config.py validate-modules:doc-default-does-not-match-spec
-plugins/modules/dellos9_config.py validate-modules:doc-missing-type
-plugins/modules/dellos9_config.py validate-modules:doc-required-mismatch
-plugins/modules/dellos9_config.py validate-modules:parameter-list-no-elements
-plugins/modules/dellos9_config.py validate-modules:parameter-type-not-in-doc
-plugins/modules/dellos9_config.py validate-modules:undocumented-parameter
-plugins/modules/dellos9_facts.py validate-modules:doc-default-does-not-match-spec
-plugins/modules/dellos9_facts.py validate-modules:doc-missing-type
-plugins/modules/dellos9_facts.py validate-modules:doc-required-mismatch
-plugins/modules/dellos9_facts.py validate-modules:parameter-list-no-elements
-plugins/modules/dellos9_facts.py validate-modules:parameter-type-not-in-doc
-plugins/modules/dellos9_facts.py validate-modules:undocumented-parameter
-plugins/action/dellos9.py action-plugin-docs # base class for deprecated network platform modules using `connection: local`
-plugins/doc_fragments/dellos9.py future-import-boilerplate
-plugins/doc_fragments/dellos9.py metaclass-boilerplate
-tests/unit/mock/path.py future-import-boilerplate
-tests/unit/mock/path.py metaclass-boilerplate
-tests/unit/mock/yaml_helper.py future-import-boilerplate
-tests/unit/mock/yaml_helper.py metaclass-boilerplate
-tests/unit/modules/conftest.py future-import-boilerplate
-tests/unit/modules/conftest.py metaclass-boilerplate
-tests/unit/modules/utils.py future-import-boilerplate
-tests/unit/modules/utils.py metaclass-boilerplate