snow/wireguard-go
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

device: prevent spurious errors while closing a device

Browse source 
When closing a device, packets that are in flight
can make it to SendBuffer, which then returns an error.
Those errors add noise but no light;
they do not reflect an actual problem.

Adding the synchronization required to prevent
this from occurring is currently expensive and error-prone.
Instead, quietly drop such packets instead of
returning an error.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
This commit is contained in:
Josh Bleecher Snyder 2020-12-14 13:34:03 -08:00 committed by Jason A. Donenfeld
parent c9e4a859ae
commit fc0aabbae9
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
device/peer.go
View file

@ -140,6 +140,11 @@ func (peer *Peer) SendBuffer(buffer []byte) error {
defer peer.device.net.RUnlock() defer peer.device.net.RUnlock()
if peer.device.net.bind == nil { if peer.device.net.bind == nil {
// Packets can leak through to SendBuffer while the device is closing.
// When that happens, drop them silently to avoid spurious errors.
if peer.device.isClosed.Get() {
return nil
}
return errors.New("no bind") return errors.New("no bind")
} }