From f9dac7099ef1dd46ed03e8aa8453f3c5211954b8 Mon Sep 17 00:00:00 2001 From: "Jason A. Donenfeld" Date: Mon, 22 Feb 2021 15:43:08 +0100 Subject: [PATCH] global: remove TODO name graffiti Googlers have a habit of graffiting their name in TODO items that then are never addressed, and other people won't go near those because they're marked territory of another animal. I've been gradually cleaning these up as I see them, but this commit just goes all the way and removes the remaining stragglers. Signed-off-by: Jason A. Donenfeld --- device/noise-protocol.go | 1 - device/send.go | 2 +- tun/tuntest/tuntest.go | 4 ++-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/device/noise-protocol.go b/device/noise-protocol.go index e89721f..0212b7d 100644 --- a/device/noise-protocol.go +++ b/device/noise-protocol.go @@ -20,7 +20,6 @@ import ( type handshakeState int -// TODO(crawshaw): add commentary describing each state and the transitions const ( handshakeZeroed = handshakeState(iota) handshakeInitiationCreated diff --git a/device/send.go b/device/send.go index 6a3b30b..cb1607b 100644 --- a/device/send.go +++ b/device/send.go @@ -421,7 +421,7 @@ func (peer *Peer) RoutineSequentialSender() { // This is an optimization only. It is possible for the peer to be stopped // immediately after this check, in which case, elem will get processed. // The timers and SendBuffer code are resilient to a few stragglers. - // TODO(josharian): rework peer shutdown order to ensure + // TODO: rework peer shutdown order to ensure // that we never accidentally keep timers alive longer than necessary. device.PutMessageBuffer(elem.buffer) device.PutOutboundElement(elem) diff --git a/tun/tuntest/tuntest.go b/tun/tuntest/tuntest.go index 92aa9d8..d89db71 100644 --- a/tun/tuntest/tuntest.go +++ b/tun/tuntest/tuntest.go @@ -113,7 +113,7 @@ func (t *chTun) File() *os.File { return nil } func (t *chTun) Read(data []byte, offset int) (int, error) { select { case <-t.c.closed: - return 0, io.EOF // TODO(crawshaw): what is the correct error value? + return 0, os.ErrClosed case msg := <-t.c.Outbound: return copy(data[offset:], msg), nil } @@ -130,7 +130,7 @@ func (t *chTun) Write(data []byte, offset int) (int, error) { copy(msg, data[offset:]) select { case <-t.c.closed: - return 0, io.EOF // TODO(crawshaw): what is the correct error value? + return 0, os.ErrClosed case t.c.Inbound <- msg: return len(data) - offset, nil }