snow/wireguard-go
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

device: only propagate roaming value before peer is referenced elsewhere

Browse source 
A peer.endpoint never becomes nil after being not-nil, so creation is
the only time we actually need to set this. This prevents a race from
when the variable is actually used elsewhere, and allows us to avoid an
expensive atomic.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
This commit is contained in:
Jason A. Donenfeld 2021-11-16 21:13:55 +01:00
parent fc4f975a4d
commit de7c702ace
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
device/uapi.go
View file

@ -261,7 +261,9 @@ func (peer *ipcSetPeer) handlePostConfig() {
if peer.Peer == nil || peer.dummy { if peer.Peer == nil || peer.dummy {
return return
} }
if peer.created {
peer.disableRoaming = peer.device.net.brokenRoaming && peer.endpoint != nil peer.disableRoaming = peer.device.net.brokenRoaming && peer.endpoint != nil
}
if peer.device.isUp() { if peer.device.isUp() {
peer.Start() peer.Start()
if peer.pkaOn { if peer.pkaOn {