From d840445e9bdd4f4db3538c9caf93d797cc987fbc Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Thu, 21 Jan 2021 09:26:14 -0800 Subject: [PATCH] device: don't track device interface state in RoutineTUNEventReader We already track this state elsewhere. No need to duplicate. The cost of calling changeState is negligible. Signed-off-by: Josh Bleecher Snyder --- device/tun.go | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/device/tun.go b/device/tun.go index 17c2493..4af9548 100644 --- a/device/tun.go +++ b/device/tun.go @@ -15,7 +15,6 @@ import ( const DefaultMTU = 1420 func (device *Device) RoutineTUNEventReader() { - setUp := false device.log.Verbosef("Routine: event worker - started") for event := range device.tun.device.Events() { @@ -40,15 +39,13 @@ func (device *Device) RoutineTUNEventReader() { } } - if event&tun.EventUp != 0 && !setUp { - device.log.Verbosef("Interface set up") - setUp = true + if event&tun.EventUp != 0 { + device.log.Verbosef("Interface up requested") device.Up() } - if event&tun.EventDown != 0 && setUp { - device.log.Verbosef("Interface set down") - setUp = false + if event&tun.EventDown != 0 { + device.log.Verbosef("Interface down requested") device.Down() } }