From af408eb9400bd94a01eea5ece8fa3da62c911818 Mon Sep 17 00:00:00 2001
From: Josh Bleecher Snyder <josh@tailscale.com>
Date: Mon, 8 Feb 2021 11:36:55 -0800
Subject: [PATCH] device: print direction when ping transit fails

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
---
 device/device_test.go | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/device/device_test.go b/device/device_test.go
index 56ecd17..3ff35e7 100644
--- a/device/device_test.go
+++ b/device/device_test.go
@@ -8,7 +8,6 @@ package device
 import (
 	"bytes"
 	"encoding/hex"
-	"errors"
 	"fmt"
 	"io/ioutil"
 	"math/rand"
@@ -103,6 +102,13 @@ const (
 	Pong SendDirection = false
 )
 
+func (d SendDirection) String() string {
+	if d == Ping {
+		return "ping"
+	}
+	return "pong"
+}
+
 func (pair *testPair) Send(tb testing.TB, ping SendDirection, done chan struct{}) {
 	tb.Helper()
 	p0, p1 := pair[0], pair[1]
@@ -118,10 +124,10 @@ func (pair *testPair) Send(tb testing.TB, ping SendDirection, done chan struct{}
 	select {
 	case msgRecv := <-p0.tun.Inbound:
 		if !bytes.Equal(msg, msgRecv) {
-			err = errors.New("ping did not transit correctly")
+			err = fmt.Errorf("%s did not transit correctly", ping)
 		}
 	case <-timer.C:
-		err = errors.New("ping did not transit")
+		err = fmt.Errorf("%s did not transit", ping)
 	case <-done:
 	}
 	if err != nil {