From 6228659a9136014c5a96c2a4f9f5e3678b0d1e08 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Tue, 30 Mar 2021 12:36:59 -0700 Subject: [PATCH] device: handle broader range of errors in RoutineReceiveIncoming RoutineReceiveIncoming exits immediately on net.ErrClosed, but not on other errors. However, for errors that are known to be permanent, such as syscall.EAFNOSUPPORT, we may as well exit immediately instead of retrying. This considerably speeds up the package device tests right now, because the Bind sometimes (incorrectly) returns syscall.EAFNOSUPPORT instead of net.ErrClosed. Signed-off-by: Josh Bleecher Snyder --- device/receive.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/device/receive.go b/device/receive.go index b1959c6..5ddb66c 100644 --- a/device/receive.go +++ b/device/receive.go @@ -104,6 +104,9 @@ func (device *Device) RoutineReceiveIncoming(IP int, bind conn.Bind) { if errors.Is(err, net.ErrClosed) { return } + if neterr, ok := err.(net.Error); ok && !neterr.Temporary() { + return + } device.log.Errorf("Failed to receive packet: %v", err) if deathSpiral < 10 { deathSpiral++