snow/wireguard-go
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

wintun: Clean excessive setupapi.DevInfo.GetDeviceInfoListDetail() call

Browse source 
Signed-off-by: Simon Rozman <simon@rozman.si>
This commit is contained in:
Simon Rozman 2019-02-07 20:49:41 +01:00
parent ef48d4fa95
commit 043b7e8013
1 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
tun/wintun/wintun_windows.go
View file

@ -45,13 +45,6 @@ func GetInterface(ifname string, hwndParent uintptr) (*Wintun, error) {
} }
defer devInfoList.Close() defer devInfoList.Close()
// Retrieve information associated with a device information set.
// TODO: Is this really necessary?
_, err = devInfoList.GetDeviceInfoListDetail()
if err != nil {
return nil, err
}
// Windows requires each interface to have a different name. When // Windows requires each interface to have a different name. When
// enforcing this, Windows treats interface names case-insensitive. If an // enforcing this, Windows treats interface names case-insensitive. If an
// interface "FooBar" exists and this function reports there is no // interface "FooBar" exists and this function reports there is no
@ -266,13 +259,6 @@ func (wintun *Wintun) DeleteInterface(hwndParent uintptr) (bool, bool, error) {
} }
defer devInfoList.Close() defer devInfoList.Close()
// Retrieve information associated with a device information set.
// TODO: Is this really necessary?
_, err = devInfoList.GetDeviceInfoListDetail()
if err != nil {
return false, false, err
}
// Iterate. // Iterate.
for index := 0; ; index++ { for index := 0; ; index++ {
// Get the device from the list. // Get the device from the list.