Commit graph

43 commits

Author SHA1 Message Date
Doug Torrance a332db862a wmgeneral: Add support for X geometry strings to -geometry option.
In particular, we can specify the offsets from the right and bottom of the
screen using '-', e.g., '-geometry -64-64' places the dockapp in the lower
right corner of the screen.
2015-05-28 00:36:23 +01:00
Doug Torrance 2e2937620d wmgeneral: Add _POSIX_C_SOURCE #defines for strdup, pid_t, and getline. 2015-05-26 08:22:14 +01:00
Doug Torrance 7e04b6a890 wmgeneral: Fix "unused variable" warning. 2015-05-26 08:22:14 +01:00
Doug Torrance 5cfb385d02 wmppp.app: Bump to version 1.3.1. 2015-05-20 10:44:41 +01:00
Doug Torrance a75edac40d wmppp.app: Command line options take precedence over configuration files.
Since we now reread the configuration files on occasion, the options given
at the command line could be overwritten.  To avoid this, we save the
command line options and always use them if present.
2015-05-20 10:44:41 +01:00
Doug Torrance 3c16ef37ec wmppp.app: Reread configuration file.
Based in part on a patch by Chris Gray [1] to fix Debian bug #50181 [2].

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=12;filename=wmppp.diff;att=1;bug=50181
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=50181
2015-05-20 10:44:41 +01:00
Doug Torrance 2b0feb59f8 wmppp.app: Add new command line options.
We add command line options for the user to change the start, stop, speed,
ifdown, and stampfile settings at runtime.  This closes a Debian wishlist
bug [1].

Note that, in order to have the command line options overwrite the
defaults set in the configuration file, we split the command line parsing
code into a new function (parse_cmdline()).  We then merged main() and
wmppp_routine().

We document the new options in the help text and in the man page.  We also
take the opportunity to reformat the help text for the -i option and add
the -geometry option to the man page.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=293839
2015-05-20 10:44:41 +01:00
Doug Torrance 540b8ac560 wmppp.app: Fix segfault if stop_action or start_action strings are NULL. 2015-05-20 10:44:41 +01:00
Doug Torrance 37acf2a687 wmppp.app: Fix segfault when HOME undefined.
Instead, we exit with an error message.

This fixes Debian bug #716472 [1].

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=716472
2015-05-20 10:44:41 +01:00
Doug Torrance 7631c7d566 wmppp.app: Update Makefile.
Main change is to use $(INSTALL) instead of cp in install target along with
$(DESTDIR) variable.  We also remove installation of user ~/.wmppprc config
file -- this isn't useful for sysadmins or package maintainers.

We also update INSTALL to reflect the changes.
2015-05-20 10:44:41 +01:00
Doug Torrance 9dab93996e wmppp.app: Use #includes from include-what-you-use.
We actually include <sys/socket.h> instead of <bits/socket_type.h>, as it
returns an error: "Never include <bits/socket_type.h> directly; use
<sys/socket.h> instead."
2015-05-20 10:44:41 +01:00
Doug Torrance b14003c1ee wmppp.app: Remove C++ style comments. 2015-05-20 10:44:41 +01:00
Doug Torrance c1b23f6a43 wmppp.app: Replace deprecated usleep with nanosleep. 2015-05-20 10:44:41 +01:00
Doug Torrance 7ec61f487b wmppp.app: Replace deprecated caddr_t cast with void*. 2015-05-20 10:44:41 +01:00
Doug Torrance 40aaf4c6af wmppp.app: Remove unused parameter from get_statistics().
Fixes "warning: unused parameter ‘devname’" compiler warning.
2015-05-20 10:44:41 +01:00
Doug Torrance 82aceda014 wmppp.app: Switch ifs to #ifs for macros.
Fixes "warning: null argument where non-null required" compiler warnings by
not passing NULL to strdup and "(warning) Conversion of string literal to
bool always evaluates to true" found by cppcheck.
2015-05-20 10:44:41 +01:00
Doug Torrance 8d3011886d wmppp.app: Reduce scope of several variables.
Fixes several "(style) The scope of the variable 'p' can be reduced" found
by cppcheck.
2015-05-20 10:44:41 +01:00
Doug Torrance 6b8351219c wmppp.app: Fix spelling mistakes.
Used codespell -w.
2015-05-20 10:44:41 +01:00
Doug Torrance 9d8970e27a wmppp.app: Move source files to top directory.
This way, users need only type "make" to build instead of needing to
"cd wmppp" first.
2015-05-20 10:44:41 +01:00
Doug Torrance 624b2898fe wmgeneral: Don't call free on pointers we haven't malloced.
Could cause occasional segfaults.
2015-05-20 10:44:41 +01:00
Doug Torrance a9b73f2fd6 wmgeneral: Fix segfault if newline encountered in parse_rcfile.
From a patch for wmppp.app by Chris Gray <cgray@tribsoft.com> submitted to
Debian to fix several bugs [1].

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=27997
2015-05-20 10:44:41 +01:00
Doug Torrance cd30d4127d wmgeneral: Add proper copyright headers; fix changelog formatting. 2015-05-20 10:44:41 +01:00
Doug Torrance afd3d56aea wmgeneral: Use #includes from include-what-you-use. 2015-05-20 10:44:41 +01:00
Doug Torrance 6b1ed40882 wmgeneral: Use field width limits for scanf.
This fixes "(portability) scanf without field width limits can crash with
huge input data on some versions of libc" warning from cppcheck.

We choose 10 as the field width limit as it is the number of characters in
2^31-1, the largest int.
2015-05-20 10:44:41 +01:00
Doug Torrance a0f16b945a wmgeneral: Reduce scope of several variables.
Also took the opportunity to fix some whitespace formatting.
2015-05-20 10:44:41 +01:00
Doug Torrance 6dc4716c29 wmgeneral: Merge 2003-10-10 version from wmmon and wmtime.
Note that this was a fork of the earlier 1998-05-02 version and didn't
contain the later changes.  Therefore we merge the best of both versions.

wmtime had some additional unnecessary dummy variables, so we use the wmmon
version.
2015-05-20 10:44:41 +01:00
Doug Torrance a680f87666 wmgeneral: Bump to 1998-09-14 version found in wmckgmail, wmitime, wmsmp.app, wmSMPmon, and wmtz.
Note that wmckgmail and wmtz were identical; this is the version we use.
wmSMPmon differed only with some whitespace.

wmitime differed only with a bugfix (a segfault when -display is given with
no argument), but this will be fixed again in the next commit.

wmsm.app had patched wmgeneral to work with its xpm; instead we patch its
xpm to work with wmgeneral.
2015-05-20 10:44:40 +01:00
Doug Torrance 7d77c17cc1 wmgeneral: Remove inline keywords.
Previously, if we attempted to build using C99 or later, we got "inline
function declared but never defined" warnings and eventual "undefined
reference" errors.  As a result, it fails to build from source using gcc5.

However, if we move the definitions to list.h and add "extern inline"
declarations to list.c, which does compile using C99 and later, then it no
longer compiles using gnu90, the default for gcc4.

To avoid this mess, we remove the inline keywords altogether.

Note that this fixes Debian bugs for wmifs [1], wmppp.app [2], and
wmtime [3].

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778170
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778172
[3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778174
2015-05-20 10:44:40 +01:00
Doug Torrance dae24a2f5d wmgeneral: Free pointer.
Fixes "(error) Memory leak: argv" found by cppcheck.
2015-05-20 10:44:40 +01:00
Doug Torrance 746c4b6b7c wmgeneral: Check if malloc fails.
Fixes "(error) Uninitialized variable: ret" found by cppcheck.
2015-05-20 10:44:40 +01:00
Doug Torrance 0e0d4944ac wmppp.app: Update support email address and webpage. 2014-09-15 11:30:07 +01:00
Doug Torrance 3f3a1f86ac wmppp.app: Use build flags.
Compile with CPPFLAGS and LDFLAGS and append, rather than overwrite, CFLAGS.

This enables the Debian package to be built with hardening options.  See
https://wiki.debian.org/Hardening.
2014-09-15 11:30:07 +01:00
Doug Torrance 33d2784d26 wmppp.app: Use rm -f for make clean
This patch prevents "make clean" from failing when the source tree is already
clean.
2014-09-15 11:30:07 +01:00
Doug Torrance ae3f75c09e wmppp.app: Display speed in K when too high.
When the download speed is too high, wmppp can't display it because it has
only 5 digit. The most significant digits are hidden !

This small patch display the speed in K when it is too high.

Based on the patch by jguiton <jguiton@free.fr>.
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=328699.
2014-09-15 11:30:07 +01:00
Doug Torrance e81a5eb522 wmppp.app: Stampfile handling.
This patch adds support for "stampfile" in config file, as described in
manual page.

Based on the patch by Juan Cespedes <cespedes@debian.org>.
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=97509.
2014-09-15 11:30:07 +01:00
Doug Torrance b47834fe0b wmppp.app: Allow ISDN devices.
Users of ISDN dialup lines (such as me) cannot use wmppp as shipped,
because it rejects to use any device except those beginning with `ppp'.

The patch attached solves this.

Based on the patch by Juan Cespedes <cespedes@debian.org>.
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=97509.
2014-09-15 11:30:07 +01:00
Doug Torrance 9e02f15e59 wmppp.app: Rename system wide fixed options configuration file for consistency. 2014-09-15 11:30:06 +01:00
Doug Torrance 070bddbe13 wmppp.app: Add manpage (obtained from Debian package). 2014-09-15 11:30:06 +01:00
Doug Torrance a60b95bc13 wmppp.app: Remove trailing whitespace. 2014-09-15 11:30:06 +01:00
Doug Torrance bf86800181 wmppp.app: Remove getmodemspeed binary from source. 2014-09-15 11:30:06 +01:00
Alexey I. Froloff 792a5d290a Mass update FSF address
Signed-off-by: Alexey I. Froloff <raorn@raorn.name>
2012-06-05 20:50:13 +01:00
Alexey I. Froloff 31c2845466 Mass update GPLv2 from http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt
Signed-off-by: Alexey I. Froloff <raorn@raorn.name>
2012-06-05 20:45:40 +01:00
Carlos R. Mafra 21625f40b5 Initial dockapps git repo
I tried to get the latest versions from dockapps.org, but I haven't
tested any of them.

More dockapps will be added as time permits.
2011-03-25 19:45:13 +01:00