snow/dockapps
1
0
Fork 0
Code Issues Releases Activity
346 commits 1 branch 0 tags 6.2 MiB
Commit graph

14 commits

Author SHA1 Message Date
Doug Torrance 9e71c28003 wmcdplay: Centralize version number. 
Previously, the wmcdplay version number was found in numerous places.  To ease
future releases, it now appears only in configure.ac.
 2014-12-18 18:43:10 +00:00
Doug Torrance f59aef482d wmcdplay: Fix -Wsign-compare compiler warnings. 2014-12-18 18:43:10 +00:00
Doug Torrance 0716c46281 wmcdplay: Fix -Wunused-result compiler warnings. 
In particular, fix warnings of the form "warning: ignoring return value of
‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result" by
checking return value of fgets.
 2014-12-18 18:43:10 +00:00
Doug Torrance 7959aa4cda wmcdplay: Fix -Wwrite-string compiler warnings. 
Previously, compiling wmcdplay caused a large number of warnings of the form
"deprecated conversion from string constant to ‘char*’".  This was fixed by
changing "char *" declarations to "const char *", especially in the .xpm files,
and using "const_cast" as needed when an external library expected a non-const.
 2014-12-18 18:43:10 +00:00
Doug Torrance 1b1afe2d37 wmcdplay: Install art script. 
Changes include:
- The artwork files XPM/*.art are now created during build time and
  therefore have been removed from the repository.
- The script which creates them is now installed alongside the art files in
  case users would like to design their own artwork.
- The "makeall" script, whose function has been replaced by the Makefile,
  has been removed.
- The default artwork can now be chosen at compile time by the --with-art
  option to ./configure.
- Changes have been documented in ARTWORK.

Inspired in part by the Debian patch [1].

[1] http://sources.debian.net/src/wmcdplay/1.0beta1-13/debian/patches/install_art_scripts.patch/
 2014-12-18 18:43:10 +00:00
Doug Torrance dbcf95f2a2 wmcdplay: Change artwork installation directory. 
Switch from deprecated X11R6 directory to conform to Filesystem Hierarcy
Standards.

Adapted from the original Debian patch by Marcelo E. Magallon
<mmagallo@debian.org> [1] to take advantage of automake.

[1] http://sources.debian.net/src/wmcdplay/1.0beta1-13/debian/patches/change_artwork_dir.patch/
 2014-12-18 18:43:10 +00:00
Doug Torrance e3c1ce78d6 wmcdplay: Switch build system from deprecated imake to autotools. 2014-12-18 18:43:10 +00:00
Doug Torrance 4e9f4c66ab wmcdplay: Port to FreeBSD. 
As is, wmcdplay does not build on FreeBSD systems. Although it has since been
deleted, a port of wmcdplay for FreeBSD was available. It consisted primarily
of a patch to cdctl.h [1].  Include this patch when building for FreeBSD.

Based on the Debian patch [2].

[1] https://svnweb.freebsd.org/ports/head/audio/wmcdplay/files/ patch-aa?revision=56594&view=co&pathrev=56594
[2] http://sources.debian.net/src/wmcdplay/1.0beta1-13/debian/patches/kfreebsd_port.patch/
 2014-12-18 18:43:10 +00:00
Doug Torrance a16e508465 wmcdplay: Build on the Hurd. 
Fails to build from source on GNU/Hurd due to inclusion of a linux-specific
header <linux/cdrom.h>. Instead include <sys/cdrom.h>.

Patch by Samuel Thibault <sthibault@debian.org> [1], which fixes Debian bug

[1] http://sources.debian.net/src/wmcdplay/1.0beta1-13/debian/patches/fix_hurd_ftbfs.patch/
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=647964
 2014-12-18 18:43:10 +00:00
Doug Torrance 7132ad5e81 wmcdplay: Add parentheses in cdctl.h. 
This avoids the following warning during build: "warning: suggest parentheses
around assignment used as truth value [-Wparentheses]" .

Patch from Debian [1].

[1] http://sources.debian.net/src/wmcdplay/1.0beta1-13/debian/patches/add_parentheses.patch/
 2014-12-18 18:43:09 +00:00
Doug Torrance 60cb7c34e9 wmcdplay: Remove extra argument to format in fprintf. 
This avoids the following warning during build: "warning: too many arguments
for format [-Wformat-extra-args]" .

Patch from Debian [1].

[1] http://sources.debian.net/src/wmcdplay/1.0beta1-13/debian/patches/remove_extra_arg.patch/
 2014-12-18 18:43:09 +00:00
Doug Torrance 149419b277 wmcdplay: Set remain variable to zero. 
This avoids an possible undeclared variable error five lines later if remain is
never set: "if(remain<2250)".

Patch from Debian [1].

[1] http://sources.debian.net/src/wmcdplay/1.0beta1-13/debian/patches/set_remain_to_zero.patch/
 2014-12-18 18:43:09 +00:00
Doug Torrance ca89668d4e wmcdplay: Add -i option so users can specify cd polling interval. 
Based on the patch from Debian by Marcelo E. Magallon <mmagallo@debian.org> [1],
which fixed Debian bug #25121.

[1] http://sources.debian.net/src/wmcdplay/1.0beta1-13/debian/patches/add_interval_option.patch/
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=25121
 2014-12-18 18:43:09 +00:00
Doug Torrance 34e3275338 wmcdplay: Add version 1.0beta1 to repository. 
Obtained from
http://sourceforge.net/projects/wmcdplay/files/wmcdplay-1.0-beta1.tgz/download
 2014-12-18 18:42:20 +00:00