Commit graph

995 commits

Author SHA1 Message Date
Doug Torrance bba01f1b6a wmbiff: Remove #define _GNU_SOURCE; already defined in CFLAGS. 2017-06-24 17:07:02 +01:00
Doug Torrance 3b000774cc wmbiff: Manually copy mailbox path.
Patch by Demi <m@tfiu.de> to fix Debian bug #621690.

From https://bugs.debian.org/621690:

> wmbiff change path of my mailboxes next nearest.
>
> For example wmbiff change 'gleb' to 'glil' for second and fourth mailboxes.
> However the 1st, 3rd and 5th mailboxes have correct path.

Well, the indices don't really enter.  I'm actually surprised this
isn't more trouble.

The underlying reason is that in wmbiff.c:parse_mbox_path, the
program calls

  mboxCreate((&mbox[item]), mbox[item].path);

which for maildirs calls

  int maildirCreate(Pop3 pc, const char *str)

in maildirClient.c.  str in this way is an alias for pc->path.

In maildirCreate, after some char acrobatics, the program eventually
does

  strncpy(pc->path, str + 8 + i, BUF_BIG - 1);

to cut off the leading stuff from the maildir.  The result of this
operation is not defined, as pc->path and str point to the same
memory and thus the arguments overlap, which strncpy outlaws.

A simple fix is to copy manually, like this:

		DM(pc, DEBUG_ERROR, "maildir '%s' is too long.\n", str + 8 + i);
		memset(pc->path, 0, BUF_BIG);
	} else {
+		const char *sp = str + 8 + i;
+		char *dp = pc->path;
+
+		while (*sp && sp-str<BUF_BIG-1) {
+			*dp++ = *sp++;
+		}
+		*dp = 0;
-		strncpy(pc->path, , BUF_BIG - 1);	/* cut off ``maildir:'' */
	}

-- it's what I'm doing now.  But I give you that's a bit pedestrian.
2017-06-24 17:07:02 +01:00
Doug Torrance 24c0e4e4f2 libdockapp: Don't withdraw dockapps in windowed mode.
In Window Maker, windows with application class "DockApp" are automatically
withdrawn.  We don't want this in windowed mode. We use the application
name instead, with the usual convention of capitalizing the initial letter.
2017-04-27 11:29:10 +01:00
Doug Torrance fa7743bc58 libdockapp: Do not include pathnames in Window Name and Class Properties
Patch by Corin-EU from GitHub [1].

In libdockapps file wmgeneral.c, wname is set from argv[0] and is then used
to set the window name and class resource. Often applications are called with
their full path which then means that the window name has a path in it,
thereby requiring an unwieldy path specific string for "Name" in WMState if
the applet is to be captured in the WM dock.

The simple solution is that wname should be the basename of argv[0] to
ensure that the window name for the applet is the simple and obvious one.
Thus the inclusion of header file libgen.h is required.

Just say "no" to path slashes "/" in window name/class resources ....

[1] https://github.com/d-torrance/dockapps/issues/5
2017-04-26 23:27:19 +01:00
Doug Torrance 139c230a8a wmtictactoe: Avoid buffer overflow by allowing room for null terminator. 2017-03-06 02:08:53 +00:00
Doug Torrance ffc4386b41 wmtictactoe: Use wmgeneral from libdockapp. 2017-03-06 02:08:53 +00:00
Doug Torrance fb561ea71b wmtictactoe: Add version 1.1 to repository.
Obtained from:
http://www.cs.mun.ca/~gstarkes/wmaker/dockapps/files/wmtictactoe-1.1-1.tar.gz
2017-03-06 02:08:53 +00:00
Doug Torrance e467912211 wmweather: Remove dockapp; still actively maintained elsewhere.
Last release August 2016.  See:
https://people.debian.org/~godisch/wmweather/
2017-03-03 12:02:31 +00:00
Doug Torrance 4a41e292cb wmxss: Delete NFS "silly rename" file.
These are created by NFS clients to help delete files.  See:
http://nfs.sourceforge.net/#faq_d2

We don't need this in git.

Reported-by: Nerijus Baliunas <nerijus@users.sourceforge.net>
2017-03-01 00:35:48 +00:00
Doug Torrance 438f06672f wmappkill: Use g_free from glib instead of glibtop_free.
gliptop_free no longer exists.
2017-02-28 10:39:21 +00:00
Doug Torrance 37712e08b0 wmappkill: Use pkg-config for glib build flags. 2017-02-28 10:39:21 +00:00
Doug Torrance 00a948e61a wmail: Specify libdockapper header file directory. 2017-02-28 10:39:21 +00:00
Doug Torrance ca965667c9 wmail: Link shared lbraries in correct order. 2017-02-28 10:39:21 +00:00
Doug Torrance 32a301b73c wmail: Remove autogenerated configure file from git. 2017-02-28 10:39:21 +00:00
Doug Torrance 38a3b251be washerdryer: Use wmgeneral from libdockapp. 2017-02-28 10:39:21 +00:00
Doug Torrance a25f4b8a73 washerdryer: Use pkg-config for GTK build flags. 2017-02-28 10:39:21 +00:00
Doug Torrance efb171a5dc cnslock: Bump to version 1.03. 2017-02-28 10:38:00 +00:00
Doug Torrance 93c3d0ca7e cnslock: Add desktop entry file. 2017-02-28 10:38:00 +00:00
Doug Torrance 1d20d16ccb cnslock: Add manpage. 2017-02-28 10:38:00 +00:00
Doug Torrance 743b72fc4e cnslock: Update documentation. 2017-02-28 10:38:00 +00:00
Doug Torrance ca28db136e cnslock: Switch to autotools. 2017-02-28 10:38:00 +00:00
Doug Torrance eb6ba359cb cnslock: Complete rewrite using libdockapp.
No longer functioned as a dockapp using modern GDK 2.0, which is what cnslock
previously used.
2017-02-28 10:38:00 +00:00
Doug Torrance dac0305f26 wmymail: Update libdockapp path. 2017-02-26 01:37:41 +00:00
Doug Torrance b3ffc7a46c wmxss: Remove precompiled binary and object files. 2017-02-26 01:37:41 +00:00
Doug Torrance 72d06f7028 wmswallow: Link against libX11. 2017-02-26 01:37:41 +00:00
Doug Torrance ea4b9ec5c8 wmfortune: Use short unsigned int for dockapp dimensions.
Avoids incompatible pointer type warnings.
2017-02-25 10:11:28 +00:00
Doug Torrance 01630fdc00 wmdots: Fix typo in Makefile - use correct name for binary. 2017-02-25 10:11:28 +00:00
Doug Torrance d16b8d585f wmdots: Rename local sincos() to avoid conflicting types warning. 2017-02-25 10:11:28 +00:00
Doug Torrance ba57b20d96 wmdots: Include string.h. 2017-02-25 10:11:28 +00:00
Doug Torrance 9a6c70ebbc wmdots: Add -f option to rm for clean target in Makefile. 2017-02-25 10:11:28 +00:00
Doug Torrance 392c469fd4 wmdots: Move files up one directory.
Since wmgeneral directory no longer exists, having wmdots/wmdots/* seems
pointless.
2017-02-25 10:11:28 +00:00
Doug Torrance 4ee6de24cc wmdots: Use wmgeneral from libdockapp. 2017-02-25 10:11:28 +00:00
Doug Torrance 6364a53061 wmdots: Remove precompiled binary and object files. 2017-02-25 10:11:28 +00:00
Doug Torrance 115ec5e4c1 wmpop3lb: Use wmgeneral from libdockapp. 2017-02-24 10:08:06 +00:00
Doug Torrance 9c0d22f0c2 wmpop3: Use wmgeneral from libdockapp. 2017-02-24 10:08:06 +00:00
Doug Torrance 699726230b wmomikuzi: main() returns an int. 2017-02-24 10:08:06 +00:00
Doug Torrance fbb8c1f3da wmomikuzi: Use short unsigned ints for dockapp dimensions.
Fixes "incompatible pointer type" warnings.
2017-02-24 10:08:06 +00:00
Doug Torrance 64e18be573 wmomikuzi: Don't try and compile local libdockapp. 2017-02-24 10:08:06 +00:00
Doug Torrance 18d0b3e910 wmmoonclock: Remove Debian directory. 2017-02-24 10:08:06 +00:00
Doug Torrance e8ff535c75 wmhexaclock: Remove precompiled binary from git. 2017-02-24 10:08:06 +00:00
Doug Torrance a44f3795a0 wmfu: Indicate directory of wireless header file. 2017-02-24 10:08:06 +00:00
Doug Torrance 3f39807282 wmfemon: Fix linking order to avoid undefined reference errors. 2017-02-24 10:08:05 +00:00
Doug Torrance 8b09e991af wmdonkeymon: Remove unused wmgeneral files list.* and misc.*.
Still using wmdonkeymon's version of wmgeneral.* as it adds a new function
not available in libdockapp yet.
2017-02-22 12:35:00 +00:00
Doug Torrance 7227f253e1 wmcapshare: Update libdockapp header path. 2017-02-22 12:35:00 +00:00
Doug Torrance da39a6cd22 wmcapshare: Include glib header. 2017-02-22 12:35:00 +00:00
Doug Torrance 86b0defa79 wmcapshare: Use pkg-config instead of deprecated glib-config. 2017-02-22 12:35:00 +00:00
Doug Torrance 0e512856f3 wmcalendar: Fix capitalization in type name. 2017-02-22 10:48:05 +00:00
Doug Torrance 6778126403 wmcalendar: Add format string to printf(). 2017-02-22 10:48:05 +00:00
Doug Torrance 63dadf4eb3 wmcalendar: Update local headers to fix implicit declaration warnings. 2017-02-22 10:48:05 +00:00
Doug Torrance 67f2bbd53a wmcalendar: Include math.h. 2017-02-22 10:48:04 +00:00