Commit graph

74 commits

Author SHA1 Message Date
Doug Torrance 746c4b6b7c wmgeneral: Check if malloc fails.
Fixes "(error) Uninitialized variable: ret" found by cppcheck.
2015-05-20 10:44:40 +01:00
Doug Torrance 7e5fa243a6 wmifs: Bump to version 1.4. 2014-10-23 08:03:32 +01:00
Doug Torrance 6fb72da2ec wmifs: Add manpage.
Obtained from Debian:
http://sources.debian.net/data/main/w/wmifs/1.3b1-22/debian/wmifs.1
2014-10-23 08:03:32 +01:00
Doug Torrance 2a7a1a215d wmifs: Avoid NULL arguments to strdup.
This prevents several compiler warnings such as the following:
wmifs.c:422:3: warning: null argument where non-null required (argument 1) [-Wnonnull]
   left_action = strdup(LEFT_ACTION);
   ^
2014-10-23 08:03:32 +01:00
Doug Torrance 3b4c28b9bc wmifs: Use result of fgets.
Remove several compiler warnings of the form
wmifs.c:666:7: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result]
  fgets(temp, BUFFER_SIZE, fp);
       ^
2014-10-23 08:03:32 +01:00
Doug Torrance 55f6e28253 wmifs: Update email and homepage. 2014-10-23 08:03:32 +01:00
Doug Torrance bf67efc3c0 wmifs: Update FSF address. 2014-10-23 08:03:32 +01:00
Doug Torrance c605646c40 wmifs: Update COPYING from http://www.gnu.org/licenses/gpl-2.0.txt. 2014-10-23 08:03:32 +01:00
Doug Torrance c37f6eda98 wmifs: Use consistent formatting style.
Format to minimize warnings and errors from checkpatch.pl in the Window Maker
source tree.
2014-10-23 08:03:32 +01:00
Doug Torrance 6083e3f774 wmifs: Remove libc5 version.
libc6 was released in 1997...
2014-10-23 08:03:32 +01:00
Doug Torrance a62dcaebc7 wmifs: Delete trailing whitespace. 2014-10-23 08:03:32 +01:00
Doug Torrance 44300ffec2 wmifs: Remaining Debian patches.
This patch consists of all remaining differences between the Debian package
version 1.3b1-22 and the original upstream source.  They were not mentioned
in the Debian changelog.
2014-10-23 08:03:32 +01:00
Doug Torrance 9027310f87 wmifs: Add #defines not appearing on all archs.
Patch by Martin A. Godisch <godisch@debian.org>.  First appeared in Debian
package version 1.3b1-20.  Revised in version 1.3b1-21.
2014-10-23 08:03:31 +01:00
Doug Torrance 09ab3c0549 wmifs: Add auto interface.
Patch by Tom Marshall <tommy@home.tig-grr.com>.  First appeared in Debian
package version 1.3b1-15.

For more information, see:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=204873
2014-10-23 08:03:31 +01:00
Doug Torrance 279d4dee91 wmifs: Make sampling and scrolling intervals customizable.
Patch by Peter Samuelson <peter@samba-tng.org>.  First appeared in Debian
package version 1.3b1-14.

For more information, see:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=226689
2014-10-23 08:03:31 +01:00
Doug Torrance 49ecb83c8d wmifs: Display long interface names.
Patch by Davi Leal <davileal@terra.es>.  First appeared in Debian package
version 1.3b1-10.  Revised by Matyas Koszik <koszik@debijan.lonyay.edu.hu> for
version 1.3b1-11.

For more information, see:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=103083
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=126501
2014-10-23 08:03:31 +01:00
Doug Torrance 6e208d3f75 wmifs: Add lock mode.
Patch by Jorge García <Jorge.Garcia@uv.es>  First appeared in Debian package
version 1.3b1-7, revised in 1.3b1-8.

For more information, see:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=26870
2014-10-23 08:03:31 +01:00
Doug Torrance 44d68e454e wmifs: Update Makefile.
Patch by Jordi Mallach <jordi@debian.org>.  First appeared in Debian package
version 1.3b1-6.

See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=27458 for more
information.
2014-10-23 08:03:31 +01:00
Doug Torrance d40bd41287 wmifs: Update WMIFS_VERSION constant; update Changes.
Patch by Jordi Mallach <jordi@debian.org>.  First appeared in Debian package
version 1.3b1-6.
2014-10-23 08:03:31 +01:00
Doug Torrance 68555562b4 wmifs: Prevent crash when too many devices.
Patch by Chris Hanson <cph@martigny.ai.mit.edu>.  First appeared in Debian
package 1.3b1-6.

From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=39922:
wmifs crashes with a cryptic X error message when there are more than
4 net devices.  This occurs for me because I install vmware, which
installs 4 network devices for its bridging hack.

The bug is a loop that fills a fixed-length array, but doesn't stop
when the array is full.  The fix is to add a conditional break to the
loop.  A patch appears below.

I made two additional changes: (1) increased the size of the array,
and (2) changed a name comparison to compare all of the characters of
the name, rather than just the visible characters, since there may be
multiple net devices with the same first 4 characters (vmware does
this, too).
2014-10-23 08:03:31 +01:00
Doug Torrance c2155050c7 wmifs: Prevent speedy scrolling problem.
Patch by Barak Pearlmutter <bap@cs.unm.edu>.  First appeared in Debian package
version 1.3b1-6.

From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=83003:
On my laptop, following a suspend, wmifs scrolls like nuts for a long
time.  The scroll speed looks the same as for a wmifs that is paused
for a while using C-z.

Here is a patch that prevents this speedy scrolling problem.  I also
got rid of a couple unnecessary compiler warnings.
2014-10-23 08:03:31 +01:00
Doug Torrance ac2050270e wmifs: Remove "heyho!" debugging message.
Patch by Ben Gertzfield <che@debian.org>.  First appeared in Debian package
version 1.3b1-5.

See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=42297 for
more information.
2014-10-23 08:03:31 +01:00
Doug Torrance 3bd48a06c5 wmifs: Add BUFFER_SIZE constant.
Patch by Stephen Pitts <smpitts@midsouth.rr.com>.  First appeared in Debian
package version 1.3b1-4.

From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=41746:

wmifs started crashing on startup on my system,
so I grabbed the source, added -g to the
Makefile, and ran it through gdb.
(Wow, the wonders of Open Source!!).

I found out that it has the hard-coded assumption
that a line in  /proc/net/dev will be no longer
than 128 bytes. Since my ethernet card has over
1 GB in traffic , my eth0 line was 129 bytes long.
I added a new constant, BUFFER_SIZE, that
determines the size of the buffer used for fgets.

Right now, its at 512 bytes, so that gives it
a large margin of error, until we have petabyte
Ethernet! The patch is attached.
2014-10-23 08:03:31 +01:00
Doug Torrance 3e9e54c1e4 wmifs: Add version 1.3b1 to repository.
Source obtained from:
http://ftp.de.debian.org/debian/pool/main/w/wmifs/wmifs_1.3b1.orig.tar.gz
2014-10-23 08:03:31 +01:00