The current Makefile script doesn't work properly, because the path
for /etc doesn't use DESTDIR and the installation path for $(DESTDIR)/usr/bin
is not created before installing the binary file in the folder.
LDFLAGS are needed in some distros to build the package, for example Debian.
This patch solves these problems.
This patch is a code clean patch:
- Removes spaces and tabs at end of line.
- Remove curly brackets not needed.
- Change spaces by tabs.
- Add spaces after and before operators.
- Removes spaces not needed.
- Better code style.
- Added void as function argument.
The mouse middle button should be enabled by default (see the help
and the manpage). This patch solves this bug.
The MIDMOUSE definition is removed because the value of MIDMOUSE
changes the middle button behaviour. Now, the middle button always works,
except if the user uses the -m argument.
Now the manpage and the help show the same info.
This patch is a code clean patch:
- Removes spaces and tabs at end of line.
- Remove curly brackets not needed.
- Change spaces by tabs.
- Add spaces after and before operators.
- Removes spaces not needed.
- Better code style.
This patch is based in the code wrote by Christian Aichinger
for the Debian distribution.
Changes are:
- Removed the compilation of ctags by default
- Changed the include /usr/X11R6/include/X11 to /usr/include
- Created install option
This patch is based in the code wrote by Christian Aichinger
for the Debian distribution.
The patch includes the /etc/wmbutton.conf as global configuration
file. This file is readed if $home/.wmbutton don't exists.
The file .wmbutton is a hidden file, and is better to distribute
it as sample configuration file (sample.wmbutton).
Based on Christian Aichinger's patch.
The X11 libraries are now in include/X11 folder, instead of include
folder. Now is possible to compile the application in new systems.
This patch changes the wmbutton version in the README file too.
Based on Christian Aichinger's patch.
The original wmbutton 0.6.1 is added to the repository.
wmbutton is a dockapp with nine buttons (3x3), capable of launch 27
different applications using the left, middle and right buttons.
AM_PATH_LIBGNUTLS seems to be obsolete.
Replace the check with pkg-config using PKG_CHECK_MODULES.
AM_CONFIG_HEADER also seems to be obsolete.
Replace with AC_CONFIG_HEADER.
Fix installing an extra script (security.debian.rb)
Signed-off-by: Wade Berrier <wberrier@gmail.com>
There's no need to keep autogenerated files in
repository. Those dockapps which use autotoold must be
autoreconf'ed prior to build, those which use imake must be
xmkmf'ed. As of wmbiff, AC_PATH_XTRA_CORRECTED was a hack to
avoid bug in older autoconf version, which is no longer needed
(it's 2012 now already).
Signed-off-by: Alexey I. Froloff <raorn@raorn.name>
Added -b flag to include buffers and cache in total memory usage.
Added global show_buffers, -b parsing code, associated logic in
update_stat_mem(), and usage information.
wmmon.1
Added -b documentation.
TODO: Still need to fix dependencies.
wmmon.c:
Updated version string to 1.2b2 (forgot this for 1.2b1).
Fixed compiler warnings: added error checking for filesystem calls
and commented out some preprocessor/C code that was apparently used
to hardcode test cases.
TODO: remove completely soon if no ill effect.
wmmon/CHANGES:
Updated for 1.2b1.
wmmon/Makefile:
Added debug build with -g3; default build with -O3. Note:
This makefile isn't perfect. You must "make clean" when switching
between "make" and "make debug" otherwise objects won't compile.
I'm sure it's a simple dependency issue, but I am not an expert with
Makefiles. I intend to fix this, but it's a low priority.
wmmon/wmmon/wmmon.c:
Updated changelog. Added #define HISTORY_ENTRIES to replace hardcoded
values.
DrawStats_io():
Removed static variable global_io_scale. Replaced with a local
variable. This should improve graphing - scale was growing, but
never shrinking, meaning as time passed, graphed values were
downscaled and not displayed.
Fixed rounding errors caused by use of integer types which were
causing very small values not to appear on graph. Added code to
round very low values up, so they will appear on meter and graph.
We are making a reasonable compromise between readability and
accuracy. Side effect is that small peaks (greater than 0 but less
than our rounded-up tiny values) will actually appear as dips
instead of peaks. I feel this is acceptable, since it still conveys
an impression of "jitter" to the user. Fixing this would have
involved further modifying the data before we graph it, which would
defeat the purpose of improving accuracy.
Tweaked load bar scaling algorithm for reabality and sensitivity.
update_stat_io():
Added a "stale" timeout for static long maxdiskio (determines
scaling of load bar). New behaviour is that every couple of minutes
we discard our saved peak value and resample. This prevents an
anomalously huge I/O spike from making more typical values fail to
trigger the load bar for the rest of the app's lifetime. Side
effect will be that every couple of minutes, we will get an
anomalous spike in the load bar as it recalibrates. This anomaly
only affects the bar, not the graph.
getWidth():
Fixed integer rounding issue similar to that in DrawStats_io().
Added similar rounding code to round up very small values so we
don't have the illusion of an idle system following a huge spike.
On my openSUSE 12.1 I get this:
/usr/lib64/gcc/x86_64-suse-linux/4.6/../../../../x86_64-suse-linux/bin/ld: wmauda.o: undefined reference to symbol 'XSetWMHints'
/usr/lib64/gcc/x86_64-suse-linux/4.6/../../../../x86_64-suse-linux/bin/ld: note: 'XSetWMHints' is defined in DSO /usr/lib64/libX11.so.6 so try adding it to the linker command line
/usr/lib64/libX11.so.6: could not read symbols: Invalid operation
collect2: ld returned 1 exit status
Fix it by adding -lX11 in LIBS.
I'm forwarding a patch from Michael Bienia <geser@ubuntu.com> that
has been applied to the wmmoonclock package in Ubuntu.
It fixes a build issue that is caused by specifiying libraries before the object
files in the linker command line.
This causes a build failure as Ubuntu's ld defaults to --as-needed, see:
http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries
[Patch sent by: Felix Geyer <debfx@ubuntu.com>]
