snow/dockapps
1
0
Fork 0
Code Issues Releases Activity

wmail: fix memory leaks.

Browse source
This commit is contained in:
Jeremy Sowden 2019-05-27 22:52:08 +01:00 committed by Carlos R. Mafra
parent e0f5120b9d
commit 9f0821af1f
2 changed files with 21 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
wmail/src/config.c
View file

@ -339,6 +339,8 @@ void ReadConfigFile( bool resetConfigStrings )
} else { } else {
TRACE( "unable to open config-file \"%s\"\n", fileName ); TRACE( "unable to open config-file \"%s\"\n", fileName );
} }
free( fileName );
} else { } else {
TRACE( "unable to allocate config-file\n" ); TRACE( "unable to allocate config-file\n" );
} }

31
wmail/src/wmail.c
View file

@ -641,13 +641,9 @@ void CheckMaildir()
break; break;
} }
if( !stat( fullName, &fileStat ) == 0 ) { if( !stat( fullName, &fileStat ) == 0 )
WARNING( "Can't stat file/path \"%s\"\n", fullName ); WARNING( "Can't stat file/path \"%s\"\n", fullName );
free( fullName ); else if( S_ISDIR( fileStat.st_mode ))
continue;
}
if( S_ISDIR( fileStat.st_mode ))
{ {
if( strcmp( dirEnt->d_name, "new" ) == 0 ) { if( strcmp( dirEnt->d_name, "new" ) == 0 ) {
if( TraverseDirectory( fullName, true ) > 0 ) if( TraverseDirectory( fullName, true ) > 0 )
@ -660,6 +656,7 @@ void CheckMaildir()
} }
// directories ".", ".." and "tmp" discarded // directories ".", ".." and "tmp" discarded
} }
free( fullName );
} }
closedir( dir ); closedir( dir );
CleanupNames(); CleanupNames();
@ -692,13 +689,9 @@ int TraverseDirectory( const char *name, bool isNewMail )
break; break;
} }
if( !stat( fullName, &fileStat ) == 0 ) { if( !stat( fullName, &fileStat ) == 0 )
WARNING( "Can't stat file/path \"%s\"\n", fullName ); WARNING( "Can't stat file/path \"%s\"\n", fullName );
free( fullName ); else if( !S_ISDIR( fileStat.st_mode ))
continue;
}
if( !S_ISDIR( fileStat.st_mode ))
{ {
TRACE( "found email-file \"%s\"\n", fullName ); TRACE( "found email-file \"%s\"\n", fullName );
UpdateChecksum( &checksum, dirEnt->d_name ); UpdateChecksum( &checksum, dirEnt->d_name );
@ -714,6 +707,7 @@ int TraverseDirectory( const char *name, bool isNewMail )
} }
++mails; ++mails;
} }
free( fullName );
} }
} }
@ -906,9 +900,16 @@ char *ParseFromField( char *buf )
if(( fullName = malloc( maxLen )) == NULL ) if(( fullName = malloc( maxLen )) == NULL )
return NULL; return NULL;
if(( addressName = malloc( maxLen )) == NULL ) if(( addressName = malloc( maxLen )) == NULL )
{
free( fullName );
return NULL; return NULL;
}
if(( comment = malloc( maxLen )) == NULL ) if(( comment = malloc( maxLen )) == NULL )
{
free( fullName );
free( addressName );
return NULL; return NULL;
}
memset( fullName, '\0', maxLen ); memset( fullName, '\0', maxLen );
memset( addressName, '\0', maxLen ); memset( addressName, '\0', maxLen );
@ -1039,6 +1040,7 @@ char *ParseFromField( char *buf )
strcpy(fullName, comment); strcpy(fullName, comment);
} }
} }
free( comment );
//WARNING("Fullname: %s\nAddress: %s\n", fullName, addressName); //WARNING("Fullname: %s\nAddress: %s\n", fullName, addressName);
@ -1091,7 +1093,10 @@ void InsertName( char *name, unsigned long checksum, flag_t flag )
TRACE( "insertName: %X, \"%s\"\n", checksum, name ); TRACE( "insertName: %X, \"%s\"\n", checksum, name );
if (( item = malloc( sizeof( name_t ))) == NULL ) if (( item = malloc( sizeof( name_t ))) == NULL )
{
free( name );
return; return;
}
item->name = name; /*strdup( name );*/ item->name = name; /*strdup( name );*/
item->checksum = checksum; item->checksum = checksum;
@ -1108,6 +1113,7 @@ void RemoveLastName()
if( names != NULL ) { if( names != NULL ) {
name_t *name = names; name_t *name = names;
names = names->next; names = names->next;
free( name->name );
free( name ); free( name );
} }
} }
@ -1343,6 +1349,7 @@ void CleanupNames()
else else
last->next = name->next; last->next = name->next;
free( name->name );
free( name ); free( name );
} else { } else {
last = name; last = name;