From 4a4d34c424f491fde3ad09bd511d67666cf38389 Mon Sep 17 00:00:00 2001 From: Doug Torrance Date: Sun, 23 Nov 2014 06:46:41 -0600 Subject: [PATCH] Fix warning in update-dockapps.pl. In particular, dereference hashes passed to keys function to avoid the following warnings: keys on reference is experimental at ./update-dockapps.pl line 91. keys on reference is experimental at ./update-dockapps.pl line 113. These warnings appeared after upgrading to Perl 5.20. --- update-dockapps.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/update-dockapps.pl b/update-dockapps.pl index 41fcb31..015e166 100755 --- a/update-dockapps.pl +++ b/update-dockapps.pl @@ -88,7 +88,7 @@ foreach my $dockapp (keys %dockapps) { if (grep {$_ eq $dockapp} keys %alts) { next; } - my $latest_version = (sort by_version keys $dockapps{$dockapp})[-1]; + my $latest_version = (sort by_version keys %{$dockapps{$dockapp}})[-1]; if ($r->run("diff", "$dockapp-$latest_version", "HEAD", "--", $dockapp)) { my $commit = $r->run("log", "-1", "--pretty=format:%H", "--", $dockapp); @@ -110,7 +110,7 @@ foreach my $dockapp (keys %dockapps) { foreach my $dockapp (keys %dockapps) { my $versions = ""; - foreach my $version (reverse sort by_version keys $dockapps{$dockapp}) { + foreach my $version (reverse sort by_version keys %{$dockapps{$dockapp}}) { $versions .= "version-$version = " . $dockapps{$dockapp}{$version} . "\n"; }