snow/dockapps
1
0
Fork 0
Code Issues Releases Activity

wmbattery: fix a couple of potential memory-leaks.

Browse source 
In `cmd_crit`, if there is an allocation failure, we return from the
function immediately and leak any previously allocated memory.  Go to
the clean-up code at the end of the function instead.

Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
This commit is contained in:
Jeremy Sowden 2019-11-01 15:29:59 +00:00 committed by Carlos R. Mafra
parent be9c86487d
commit 25dacf9256
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
wmbattery/wmbattery.c
View file

@ -359,18 +359,20 @@ void cmd_crit(const char *cmd, int percentage, int time)
return; return;
tmp_b = replace_str(tmp_a, STR_SUB_MINUTES, min_str); tmp_b = replace_str(tmp_a, STR_SUB_MINUTES, min_str);
if (!tmp_b) if (!tmp_b)
return; goto free_tmp_a;
command = replace_str(tmp_b, STR_SUB_SECONDS, sec_str); command = replace_str(tmp_b, STR_SUB_SECONDS, sec_str);
if (!command) if (!command)
return; goto free_tmp_b;
ret = system(command); ret = system(command);
if (ret == -1) if (ret == -1)
error("unable to run command: %s", command); error("unable to run command: %s", command);
free(tmp_a);
free(tmp_b);
free(command); free(command);
free_tmp_b:
free(tmp_b);
free_tmp_a:
free(tmp_a);
} }
/* Returns the display to run on (or NULL for default). */ /* Returns the display to run on (or NULL for default). */